John Patrick Morgan

Results 83 comments of John Patrick Morgan

I finally spent some time on this and have made good progress, so I'll try to merge it in soon.

It took a while but I've added support for this in v0.7.0. Please let me know if you find any issues with it.

Hi @X901, thanks for raising this. I've opened a PR #28 with support for `NBNavigationSplitView`, albeit with limitations. If you have a chance to check out the branch and try...

Thanks for checking it out @X901 ! The example code you referenced is a little strange, as it sets up a `selection` property, but doesn't actually use it to show...

I played with the idea of recreating `NavigationSplitView` using `NavigationView` but there are a lot of subtle ways `NavigationSplitView` can be used, and I don't think its full functionality can...

Thanks @joprice, it's not a familiar issue and I tried to reproduce it but I wasn't able to, so a minimal reproduction would indeed be very helpful if you can....

I believe this issue is now resolved since @rhysm94's changes in version [0.9.0](https://github.com/johnpatrickmorgan/TCACoordinators/releases/tag/0.9.0).

Hi @jadar, thanks for raising this issue, sorry for the slow response. The zip file doesn't seem to include the `ContentView.swift` file, so I wasn't able to run it. Are...

Thanks @jadar! This is similar to #46 . In my response there, I suggested that view models should be stored on the navigation stack to avoid new instances being created...

I made a [change](https://github.com/johnpatrickmorgan/NavigationBackport/commit/d1759195a9be9f182b105b1ccaceff573218af6f) so that the closure is only invoked once for the same data at the same index, shipped in `v0.9.4`. Thanks for your patience!