Johan von Forstner

Results 283 comments of Johan von Forstner
trafficstars

Thank you very much! I tried to find out if there were any code changes between 27.1.1 and 28.0.0, but it seems that Google haven't uploaded a -sources.jar to their...

> Should I supply a different pull request or update this one here? I think both is fine :) Maybe you can then run a diff between the files from...

Hm, yeah, I think using `implementation` makes sense.

No, that seems to be something they changed between 27.1.1 and Material Components 1.0, ThemeUtils in 27.1.1. looks basically the same as we have it currently in our library. In...

Hm, not good either :/ Then we probably need to copy it.

😞 If it's just a Lint warning and not an error, maybe we can live with it - we update with every support library version anyway, so its not that...

Hm, but does that really affect the usage of libraries (Support Library / AndroidX) or just things that are actually in the Android SDK? I can't see any support library...

@raphaelm I think he is talking about the gray overlay behind the text. That's not a standard feature of the collapsing toolbar. It would probably be possible to create such...

Interesting idea! Adding a subtitle would probably be possible, although it would most probably make the code that calculates where the text goes and how it animates even more complicated....

Do you have any more information on how to reproduce this issue? Are you using the same version of our library and the Android Support Library, and have you set...