Johan von Forstner

Results 283 comments of Johan von Forstner
trafficstars

Thank you for your Pull request! I just tested your version using the text that you tested in #33. The expanded state looks good, but as you said, the animation...

Hey, we are currently trying to get the multiline feature merged into the official Material Components library (see [the PR](https://github.com/material-components/material-components-android/pull/413/)). However, for that, we need to make the animation work...

Hi Steve, thanks for the bug report. The reason for that is that we use `TextPaint.setAlpha(int)` in multiple places, which overrides the alpha value of the original collapsed/expandedTitleTextColor, but that...

@webserveis As written in the [README](https://github.com/opacapp/multiline-collapsingtoolbar#contributing), we can't spend much time to fix problems that don't occur in our app (we don't use transparent text there). I don't know if...

As discussed in #63 , the update to AndroidX is not a trivial task, as the library is calling a lot of internal support library interfacs which are not part...

We have now opened a PR at https://github.com/material-components/material-components-android/pull/413 and hope this feature can then be merged into the main Material Components library.

Yep, the PR is merged finally :) I'm not completely sure about the next steps, but I suppose it will be included in the next alpha release (`1.2.0-alpha05`?)

Multiline support is included in the [latest alpha release](https://github.com/material-components/material-components-android/releases/tag/1.2.0-alpha05). However, I found a small bug in this new version that still needs to be fixed: https://github.com/material-components/material-components-android/issues/1052

Does this just appear when using text in a Right-to-left language? Then there's probably an issue related to the calculation of the right margin of the expanded text.

That's currently not possible with this library. I see why it might be useful, but I think it wouldn't be very easy to implement. You would also have to handle...