Joe Littlejohn

Results 164 comments of Joe Littlejohn
trafficstars

Here's the line of code: https://github.com/joelittlejohn/jsonschema2pojo/blob/jsonschema2pojo-1.0.1/jsonschema2pojo-maven-plugin/src/main/java/org/jsonschema2pojo/maven/Jsonschema2PojoMojo.java#L789 I think the only way this could happen is if the sourceDirectory was null, but I'm not sure. Are you certain the pom.xml was...

@remcox As a workaround, if you can use something like `${project.parent.basedir}/../schemas` then this should work. To fix this, I suspect we can use `Paths.get(sourceDirectory).normalize().toString()` instead of FilenameUtils.

Thanks for pushing this so that others can use this code. I'm not sure this belongs in the core to be honest. I've never heard of any other user experiencing...

It looks like this fix will silently ignore these paths. Is that right? That doesn't seem like a good solution.

Should be an easy PR to add. Check out the FormatRule and FormatIT.

@unkish It's a good point. I've found that using appropriate types provided by the host platform is most useful, even if they are not strictly compliant. The regex example is...

Out if interest, does this work: ```java om.readValue("P1Y2M", TemporalAmount.class); ``` ?

Thanks @zhouzhipeng. A few comments on this: 1. To be consistent with the other configuration properties of this plugin, could you call your new option `useInnerClasses` instead of `genInnerClasses`? 2....

If anyone is keen to use this, feel free to pick up the review comments yourself and created a new branch based on the work that's already been done by...