Joe Littlejohn

Results 164 comments of Joe Littlejohn
trafficstars

Hmmm. I think the problem here is that this crosses the line from creating Java types that can hold valid data into generating a validator. We've never tried to do...

The rules work along the lines of: - If a property matches patternProperties, then apply the rules therein - if a property doesn't match patternProperties, does the schema support additionalProperties?...

@bestscarper it's odd to see: ``` json "patternProperties": { ".+": { "$ref": "#/definitions/codec" } } ``` as this is identical to: ``` json "additionalProperties": { "$ref": "#/definitions/codec" } ``` It's...

I like this, and I think we should definitely take many parts of it, however I wonder about the implementation here. I think we might be able to do it...

Lets leave this here for now. I'm not a fan of ignored tests in the project. I think this may be rare enough that it's not worth fixing, and given...

Thanks @eirnym. If you're interested in contributing something into this repo, please do. Whilst you're here, could you change the title in this README.adoc please: https://github.com/jsonschema2dataclass/js2d-gradle/blob/master/README.adoc The 'official' plugin resides...

@eirnym Oh, and here: https://github.com/jsonschema2dataclass/js2d-gradle/blob/fe3d93acf5c4315c42d7fb5fa7b6497ac1ab6ea5/build.gradle#L29 Thanks.

This is a very interesting use-case. At 373Kb this is probably the largest schema I have ever seen. I don't see any reason this should exhaust an 8Gb heap though,...

At one time, this plugin **did** work with m2e to generate sources as part of Eclipse's incremental build. You can see our configuration here: https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-maven-plugin/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml I'm not sure why this...

Yes, looks like there's a bug here in how the `#` reference is resolved. The first schema should just generate: ```java @Generated("jsonschema2pojo") public class Folder { @JsonProperty("folders") private List folders...