Joe Littlejohn

Results 164 comments of Joe Littlejohn
trafficstars

It's common to keep generated sources and files that are under source control separately. In fact it's rare to generate files into a source directory that you are including in...

Hi. How does the generation get screwed up?

Looks like there is some problem with the way this interacts with the 'inner builder' option.

This looks like a good change, thanks! A few comments: 1. Can you add the new annotation style to the docs in these places: https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-ant/src/site/Jsonschema2PojoTask.html#L35 https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/GenerationConfig.java#L163 https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-maven-plugin/src/main/java/org/jsonschema2pojo/maven/Jsonschema2PojoMojo.java#L247 https://github.com/joelittlejohn/jsonschema2pojo/blob/master/jsonschema2pojo-gradle-plugin/README.md 2. Add...

Hmm. I think the simplest thing is just to turn this: https://github.com/joelittlejohn/jsonschema2pojo/blob/0552b80db93214eb186e4ae45b40866cc1e7eb84/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/ObjectRule.java#L142 into this: ```java if (ruleFactory.getGenerationConfig().isIncludeConstructors() || generationConfig.getAnnotationStyle() == AnnotationStyle.VERTX) { ``` Yes?

I think there are a number of options here: 1. Create a multi-module Gradle project, you can have a different configuration per module 2. Use Maven, it allows multiple executions...

I can't think of any problem this would cause. Feel free to submit a PR for this (and please include a test case). How do you attach the @RegisterForReflection annotation...

Thanks for raising this @monksy, it sounds like a very useful addition. There's probably quite a bit of work here, but no blockers that I can think of. The `clone`...

No quick fix I'm afraid. The accessor names you see in 1.1.1 are actually compliant with the Java bean spec. They're the correct names (because two capitals would indicate a...

Often people use union types like: `["boolean", null]`, where the result is an optional value. In this case, it's obviously desirable to just take the first item. It would probably...