James Herdman

Results 147 comments of James Herdman

@jfdnc the Metrics service refactor has been merged. Are you interested in getting your GA refactor in too?

@jfdnc I had another thought this morning I wanted to bounce off of you. A while back I investigated https://github.com/DavidWells/analytics as a possible underpinning for this library. One of the...

IMHO plain JavaScript is better, i.e. `Base.detroy()` with `.willDestroy()` exposed. Reduced cognitive overhead, etc. > Another related thought here is that the adapters are targeting those scripts with a CSS...

@jfdnc let's just decorate the script tags with `data-ember-cli-metrics` to keep things easy.

I'll stop dragging my buns on a deprecation PR so that this can move forward. My apologies to you both.

OK, the initial deprecation PR is merged. The next step is to deprecate the `init` method altogether. My gut feeling is that #316 is somehow related to this, but I...

Having this resolved for 1.0 would be dandy too https://github.com/ember-engines/ember-engines/issues/625

I'm experiencing this problem too. Following some advice in another issue I set my engine's resolver for the integration test. This did not resolve my issue.

This should be theoretically closed by #124, but that doesn't seem to be the case in the latest release.

Note that this issue was not present in the 0.5 series.