James Herdman

Results 147 comments of James Herdman
trafficstars

I don't believe this is correct either. I'm working on a project that has some Vue code, and some plain JS. If I implement your change I see this despite...

I've tracked this down to a problem in my own configuration. I have a rule supplied by Shakapacker that looks like this: ```javascript test: /\.html$/, exclude: /\.(js|mjs|jsx|ts|tsx)$/, type: 'asset/source' }...

This is also of interest to us at Precision Nutrition. We use BEM to organize our CSS and would like to apply this to our flash styles without having to...

Super cool! Many thanks for the heads up.

To be honest, I haven't the foggiest clue. If you look at the first commit with this code you'll see that it's pretty much been there since its inception: 86d7e1273fb315e24b8d9b95e7ee4a0b81402b21....

I should not that it should be done in two phases: 1. A deprecation warning indicating the new behaviour 2. A PR that will remove the old behaviour when we...

You're right, my apologies for that. I'll keep this issue open for a few days just in case there are a few other affected consumers. If it's bad enough I'll...

I'm going to revert this, but leave `-private` in so there's not too much thrash. v2 will remove `-private`. What a mess!

I don't have access to do this. Maybe @MelSumner does?

Some high level thoughts as I'm chewing on this still: - [ ] I like your service refactor and GA refactor. Would you be amenable to making these their own...