James Herdman
James Herdman
Hey Jeff. In the end I found that @NullVoxPopuli 's solution worked for me. The key seems to be configuring in `included` _and_ having the options set directly on the...
@MelSumner if a reasonable path forward cannot be determined with the package as-is, I'm all for something new.
This is going to take a little while to review.
Let's split this PR in two as you suggested. I'm not familiar with Embroider so it'll take a while to get up to speed on that aspect of this fix.
Thank you for following up! With any luck that means I'm seeing some test-only fails.
Hi @evansrobert. I'm sure we can do something here. Are you interested in opening a PR that does the work to upgrade the dependency?
Hi @grantyang . I've poked a bit at trying to resolve this, but I've ran into some difficulties coming to the solution and finding the time to implement it. The...
It's my intention to migrate this addon to v2 once I sort out a few test failures with the current code. If you're interested, a pull request migrating to v2...
Ping @ivanvotti
I think this might be resolved by #186 ...