Jeremy Evans comments

Results 267 comments of


                                            Jeremy Evans

Release GVL for get{login,pwnam,pwuid,grnam}{,_r} calls in process.c

@nobu If you have time, can you please review https://github.com/ruby/ruby/pull/11202/commits/ca81d6f183452f59563342b3108b2a8ae5d10a72 and let me know if I got all of the casts correct?

Fix evaluation order issue in f(**h, &h.delete(key))

@kddnewton This is my first time contributing to the prism compiler, can you please review that part?

Fix evaluation order issue in f(**h, &h.delete(key))

No rush on this, early next week is fine. Congratulations on getting prism merged!

Fix evaluation order issue in f(**h, &h.delete(key))

Already CI failures in the allocation tests due to this. Going to revert. Not sure why all tests passed in the PR before merge.

Fix evaluation order issue in f(**h, &h.delete(key))

Not sure why allocation tests passed in this PR. I can only guess the allocation tests weren't run for prism at the time of the CI. I submitted a pull...

Make rb_obj_free use rb_ary_freeze when the target is an Array

> Certainly we could allow the buffer pointer to change even though it's frozen, it just seems very strange (to me). Isn't the buffer pointer already changed for embedded arrays...

Increase the amount of freezing

Initial estimates show this results in 213 additional failing specs, most of which is due to the mocking of classes that are now frozen. I've been thinking of an approach...

Increase the amount of freezing

I implemented additional freezing in #2154

Call a method to run all runnables

I think `run_all_methods` should only be called if there are methods to run (e.g. check `empty?` before calling the method instead of inside the method). Otherwise, this looks good. I...

Call `Set#add` from `initialize` on subclasses

I'm against this for reasons I described in the Redmine ticket. If we want to be backwards compatible, we shouldn't do it piecemeal, we need to do a complete audit...