Jeremy Evans
Jeremy Evans
I don't think this is a good idea. I believe it may it introduce a security vulnerability on Windows (where ALT_SEPARATOR is `\\`). Consider: ```ruby Rack::Utils.clean_path_info("/foo/..\\../bar") # Before: "/bar" #...
> Should `Rack::Utils.clean_path_info("/foo/..\\../bar")` be valid or perhaps raise an error? It's more work to have it raise an error. More work generally results in more complexity, and more complexity generally...
Submitted #2314 for this.
As I mentioned in #1879, I'm strongly against this approach due to the backwards compatibility issues. I doubt you will be able to get the Roda specs passing with this....
> Do you mind pointing me at the code that does this: https://github.com/jeremyevans/roda/blob/master/lib/roda/plugins/middleware.rb#L182
> All tests pass locally if I write it like this: > > ```ruby > if app.respond_to?(:to_hash) > super > else > Forwarder.new(self, app, *args, &block) > end > ```...
> > That will break creating middleware that responds to to_hash. > > Okay, so this is a hypothetical problem, but probably not a real one? There are no restrictions...
I don't think Aqualung should be taking any significant CPU when paused. Certainly it doesn't in other environments I've used (granted, mostly the sndio output, and no ladspa_dsp). Does the...
Thank you for checking. I'm not sure if this is something caused by Aqualung or could be avoided by changes to Aqualung, but I'm going to leave it open in...
From some googling, Audacious natively supports Pipewire, but Aqualung does not. Aqualung supports Pulseaudio, and then you are using pipewire-pulse to support Pipewire. Perhaps the problem is in pipewire-pulse and...