Jeremy Evans

There's already a `rescue Exception` later in the same method. I believe the reason for this is that logger should never break existing code, so any exceptions that occur while...

Timeout allows you to raise an arbitrary exception. See https://bugs.ruby-lang.org/issues/9115

If you already are aware of all exception classes that you would need to catch, and are sure that switching from swallowing all exceptions by default to only rescuing only...

> > What is correct? Are you assuming we prohibit passing any IO-like objects to logdev argument? > > As long as we allow passing IO-like objects, we can not...

Agreed that this can be a rabbit hole. While reraising all exceptions solves the timeout problem, it potentially introduces other problems that are more serious and more widespread. If you...

@sonots I'm not intending to comment further on this, but I just want to check on the status. It's now been more than a year since the previous comment was...

It's been another 3 years since the last comment, and 4 years since this was opened. This is still a significant issue in logger. I've rebased this against master. @sonots...

I think the changes are orthogonal. Supporting a max limit of redirects as in #18 seems like a good idea. However, redirects that set cookies and rely on the cookies...

I would be open to possible refactoring/method extraction so that you could override methods to get the behavior you want. However, understand that I am not the net-http maintainer, so...

I agree to apply "Ruby license or BSD-2-Clause license (dual-license)" to my commits.