Jeff Noyle

Results 16 issues of Jeff Noyle

PIX has a pass that adds "instruction ordinals" in order to have a common communication mechanism between, e.g., shader debugging instrumentation and the PIX UI. Unfortunately, the enumeration order of...

Three intertwined issues: 1: The shader-debug-instrumentation and pixel-hit-counter passes add SV_VertexId+SV_InstanceId to the input sig for a VS if they are not present, and SV_Position for the PS. The changes...

These changes are in response to comments on a cherry-pick PR in which it wasn't appropriate to address the issues immediately. The PR in question is: https://github.com/microsoft/DirectXShaderCompiler/pull/6300 fixes #6308 (file...

**Is your feature request related to a problem? Please describe.** A PIX customer had a shader in which an AllocateRayQuery handle (which is actually typed as i32) was included as...

enhancement
validation

**Description** Code issue noted in cherry-pick review: https://github.com/microsoft/DirectXShaderCompiler/pull/6300 **Steps to Reproduce** No repro. Code issue. **Actual Behavior** No behavior change expected. **Environment** Not relevant.

bug
tech-debt
PIX

**Description** See [bob80905](https://github.com/bob80905)'s comments on PR https://github.com/microsoft/DirectXShaderCompiler/pull/6300 In summary, "assert" was used when "DXASSERT" is preferred. Plus, some of the asserts are just plain "assert(false)" and could be refactored into...

bug
tech-debt
PIX

Who knew codegen could generate i25 as part of a switch argument? Not me!

Example: Given this HLSL: ``` static RWByteAddressBuffer DynamicBuffer = ResourceDescriptorHeap[1]; [numthreads(1, 1, 1)] void DynamicResources() { uint val = DynamicBuffer.Load(0u); RWByteAddressBuffer DynamicallyIndexedDynamicBuffer = ResourceDescriptorHeap[256 + val &0xf]; floatRWUAV[0] = DynamicallyIndexedDynamicBuffer.Load(0);...

bug

**Description** Attempts to compile the following code results in an internal crash in the compiler. (GetLoweredUDT() returns nullptr when passed the payload's type) (This happened while writing tests. Not a...

bug
crash
incorrect-code

- a DXIL comment pointing to the original file/line/hlsl snippet ? (rather then having to crawl through metadata) - e.g.: %270 = call float @dx.op.binary.f32(i32 35, float 0x3F1A36E2E0000000, float %269),...

enhancement
dxil