Jeff Kluge comments

Results 143 comments of


                                            Jeff Kluge

NuGetSdkResolver adds significant overhead to evaluation and should not be used

The parsed SDK versions from `global.json` are cached so it should only be read once. https://github.com/NuGet/NuGet.Client/blob/b6cd1677ae2bd3b07f4cc23c2e8d408f784e8b05/src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/NuGetSdkResolver.cs#L81 MSBuild caches the resolved path for a particular SDK so that should only happen...

NuGetSdkResolver adds significant overhead to evaluation and should not be used

@nguerrera can you double check that if you have two or more projects referencing the same SDK-from-a-NuGet-package that there is no overhead except for one? Also we still need to...

`dotnet format style` fails when requiring .NET Framework Build Host exe

This is blocking NuGet from targeting .NET 9 since we run `dotnet format` during CI. We're a little weary of disabling that step, any ETA on this getting fixed? https://dev.azure.com/dnceng-public/public/_build/results?buildId=790387&view=logs&j=aaa7ce50-1703-5ce2-816a-a202c6bd41b7&t=81ac2d4c-b79c-5e3e-9fd5-7faf8fc65909...