Jeff Kluge

Build has passed, feel free to merge.

> Even though it's unlikely, [dotnet/msbuild@986f8ec](https://github.com/dotnet/msbuild/commit/986f8ec32c74b7425e9ecf313e3a1afdf2d4f672) is the only possible change from that diff. cc @jeffkl Those changes are behind change wave 17.10, does this repo opt into that? The...

Can you please repro it locally? I am very intrigued now and want to know what's going on but don't have time to investigate myself today.

I'm not very familiar with how that is supposed to work. Are you saying `dotnet publish` should place a `.targets` in the `publish` directory? And that's not happening? Can you...

Thanks to @Forgind providing binlogs, I was able to figure out the problem. The unit tests are writing a file to `$(MSBuildProjectExtensionsPath)` [before execution](https://github.com/dotnet/sdk/blob/a571293c71a4b3bf11c12fc64c9aee88bb6ad43a/test/Microsoft.NET.TestFramework/ProjectConstruction/TestProject.cs#L458) and have taken a dependency on...

I pushed a fix at https://github.com/dotnet/sdk/pull/39088/commits/ceb443b8eb364e0e7032ac6481f8108a2942f616

Yes its considered a breaking change if: 1. You are generating files to $(MSBuildProjectExtensionsPath) 2. You need them imported for restore and build The idea is that they get imported...

Whoops, I ran the other tests with this functionality locally and they passed so I just assumed I fixed those other ones. I'll take a look later today or tomorrow.

> @jeffkl king ping as tests are still failing Sorry something else came up late last week, I'll get these working today.

The fix for this ended up being fairly simple. Instead of generating a .targets file to `$(MSBuildProjectExtensionsPath)`, the tests now generate a file to `obj` and set a property `CustomAfterMicrosoftCSharpTargets`...