Jeff Kluge

Results 143 comments of Jeff Kluge

You'll need your progress callback to return `WimMessageResult.Abort` like [this unit test](https://github.com/jeffkl/ManagedWimgApi/blob/master/src/Microsoft.Wim.Tests/ApplyImageTests.cs#L41). Depending on your application, you'll need to implement `IDisposable` which should get called when your process is killed.

I wrote a simple console application with cancellation and it appears to work with my simple test image. Debugging in Visual Studio worked if I stopped it as well. ```...

I'll try to find some time to test it out and see if there's anything I can get to work in regards to cancellation

I ran the above code and it worked just fine. Can you try registering a log file to see what it says? Please attach it as well. ```c# WimgApi.RegisterLogFile(logFile); try...

@Erarndt some tests are failing with this change https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9173771&view=ms.vss-test-web.build-test-results-tab&runId=95788042&resultId=112702&paneView=debug

Team Review: Closing this PR for now

> @jeffkl What's blocking this from making progress? I was the NuGet on-call engineer last week. Hoping to get back to this today or tomorrow, I'm also helping with the...

> @jeffkl Do you have any numbers on this? Before: ![image](https://github.com/NuGet/NuGet.Client/assets/17556515/e3383573-3d28-40b8-8e27-ca1307d2c65a) After: ![image](https://github.com/NuGet/NuGet.Client/assets/17556515/1a869020-04fb-4ac0-875d-877487766b75)

> Can you share out a trace? > […](#) > ________________________________ From: Jeff Kluge ***@***.***> Sent: Friday, April 5, 2024 6:55 AM To: NuGet/NuGet.Client ***@***.***> Cc: David Kean ***@***.***>; Review...

Here are 4 runs of before: ![image](https://github.com/NuGet/NuGet.Client/assets/17556515/c56dde17-1fb9-4b9c-b608-7e079073081e) And after: ![image](https://github.com/NuGet/NuGet.Client/assets/17556515/2945094d-3847-400b-8e0b-84cdc9aaa26b)