Jonathan Pearlin

Results 8 comments of Jonathan Pearlin
trafficstars

> I got some concern about what is going to happen for the next projects we move to micronaut about the fact that they will need to geenratetons of Bean...

> @jdpgrailsdev this Micronaut update is causing our workers to constantly crash (see below). Any idea why this might be happening? > > ``` > 2022-09-19 20:44:51 ERROR i.m.r.Micronaut(handleStartupException):338 -...

> what value should be "control" or "control-plane" ? https://github.com/airbytehq/airbyte/blob/master/charts/airbyte/templates/env-configmap.yaml#L66 @navi86 We just merged a change that sets it to `control-plane`, however that only applies to version v0.40.10 and beyond....

@pedroslopez LGTM. We should include @benmoriceau on this review as well, as he is working on a PR for `airbyte-cron` that may conflict with this one.

@pedroslopez I'm fine with merging this. We will want to do some cleanup later to avoid duplicating the configuration factory bits, but that shouldn't hold this up if we have...

@evantahler It's a bit tricky. The dashes become dots (`.`) when referencing it in the build.gradle file: `implementation libs.json.schema.validator`.

@justenwalker Micronaut actually supports the [liveness and readiness checks via a HealthIndicator implementation](https://docs.micronaut.io/latest/guide/#healthEndpoint) (see the section on Customization). This is the preferred way to implement the checks for k8 instead...

@justenwalker Thanks for converting to the Micronaut health indicators. Would you be willing to add unit tests for the indicators? I know that the implementations are currently trivial, but it...