airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Bump com.networknt:json-schema-validator to latest version

Open evantahler opened this issue 3 years ago • 2 comments
trafficstars

Closes https://github.com/airbytehq/airbyte/issues/16406

I currently have a spec which contains a pretty large oneOf (~30 subschemas) and I'm being affected by https://github.com/networknt/json-schema-validator/pull/361 in the json-schema-validator library.

Bumps com.networknt:json-schema-validator to latest version.

... all the tests seem to be passing.

Reviewers: Other than ensuring all the tests pass, what else should I check?

evantahler avatar Sep 12 '22 23:09 evantahler

NOTE :warning: Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-e2e-test
  • source-e2e-test-cloud

github-actions[bot] avatar Sep 13 '22 16:09 github-actions[bot]

/test connector=connectors/source-e2e-test

:clock2: connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/3046864165 :white_check_mark: connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/3046864165 No Python unittests run

Build Passed

Test summary info:

All Passed

evantahler avatar Sep 13 '22 16:09 evantahler

/test connector=connectors/source-e2e-test-cloud

:clock2: connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/3053953271 :x: connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/3053953271 :bug: https://gradle.com/s/dwxcxdua5zc5s

Build Failed

Test summary info:

Could not find result summary

davinchia avatar Sep 14 '22 15:09 davinchia

Same comment as Jonathan if you have time to implement!

We can add an entry similar to this and consume this just like this to centralise the declarations.

davinchia avatar Sep 14 '22 15:09 davinchia

I couldn't get the TOML part to work.

// deps.toml
[versions]
json-schema-validator_version = "1.0.72"

[libraries]
json-schema-validator = { module = "com.networknt:json-schema-validator", version.ref = "json-schema-validator_version" }

// build.gradle
dependencies {
  implementation libs.json-schema-validator
}

produced

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/evan/workspace/airbyte/airbyte/airbyte-json-validation/build.gradle' line: 6

* What went wrong:
A problem occurred evaluating project ':airbyte-json-validation'.
> Could not get unknown property 'schema' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

I'll merge this in as-is for now just to get things moving...

evantahler avatar Sep 14 '22 22:09 evantahler

@evantahler It's a bit tricky. The dashes become dots (.) when referencing it in the build.gradle file: implementation libs.json.schema.validator.

jdpgrailsdev avatar Sep 15 '22 12:09 jdpgrailsdev