Results 769 comments of James Addison

> I can refactor this PR and first remove the intersphinx legacy format in a separate one? That would help me, although it's more work for you - I'm OK...

I think that 'either' was unclear. I mean that it's either OK to separate the legacy-format-removal, _or_ OK not to and I'll review this code as-is. Just let me know...

I'm not a regular contributor here, so please take my feedback with a grain of salt. My concern about this change isn't related to the code, but to standards (in...

Yep, I've seen a few single-page applications use similar techniques, and since they can inspect the current URL from within their JavaScript code, they can implement patterns like this. We...

Using `/#/` as a special case would introduce the same problem: it'd essentially define an ad-hoc approach for how to handle some subset of URLs. I wouldn't be surprised if...

> we end up adding further specialisations and customisations, often with conflicting objectives. (or we end up coming back here and saying 'nope, sorry - we changed our minds as...

Everything after the first fragment identifier (`#`) is local to the client (and in fact not seen by the server), is my approximate understanding - so yep, I think that...

Hey @jknndy - thanks a lot for taking a look into it and experimenting with the offset functionality. A shame that it can't be parsed easily.. but it _is_ a...

> Would it be possible to use a url with the fragment to specify the recipe you want? For example, https://solarcooking.fandom.com/wiki/Casseroles#Lentil_and_Rice_Casserole will take you straight to the Lentil and Rice...

Thanks @disconsented :+1: A question / possible adjustment: is there a reason to exclude v5.1.0 in the version range? I think the breaking change introduced here was in v5.1.1 of...