Results 769 comments of James Addison

Ok, and one more thing to check: is it unacceptable in your environment to use [hyperlink text fragments](https://developer.mozilla.org/en-US/docs/Web/Text_fragments) to link to the relevant server grouping heading in `genindex.html`? (I don't...

Is the relative URL to the index on the server and computers `genindex.html` for the versions of Sphinx deployed so far?

> Can we split adding support for `.jinja` and renaming the internal template files to two PRs? That seems reasonable, yep. I've restored the original template file paths in this...

This looks like it affects Sphinx 7.1.0 onwards currently, and I do think that this would solve the problem. However: it's not great to introduce builder-specific fixes in Sphinx itself,...

Ok: now I understand that as of recently, many of the `sphinxcontrib-*` extensions no longer have Python package dependency references back to Sphinx itself. So in the short term, my...

I think my previous comments here were too hasty and cautious about this - I now think it's a reasonable solution to a genuine problem, and that unless another approach...

> We can't adopt this until 2025 (https://www.sphinx-doc.org/en/master/internals/release-process.html#python-version-support-policy). Would just using `class StrEnum(str, Enum): ...` work? > > https://github.com/python/cpython/blob/3.11/Lib/enum.py#L1273-L1303 Thanks - from some testing against both py3.9 and py3.11: that...

:white_check_mark: checked that the unit test does replicate the `dict` comparison problem reported ([first](https://github.com/sphinx-doc/sphinx/issues/11466#issue-1764087548), [second](https://github.com/sphinx-doc/sphinx/issues/11466#issuecomment-1733189376)) in the bugreport, and that the code change resolves the problem. So I think this...

This is next on my review list (I'd like to try minifying/reducing the changes to explore the differences).