james hadfield

You can test the above dataset using this PR at https://nextstrain-s-nextstrain-wpreme.herokuapp.com/staging/monkeypox/mpxv/auspice-pr-1668

I've rebased this onto master and also simplified the process by allowing any `node_attr` to be used as a strain name rather than only colourings. See https://github.com/nextstrain/mpox/pull/275 for a PR...

I don't have the expertise here to comment, but am happy to have them separated. In general, I think feature (e2e?) tests are needed. Over the years we've added amazing...

Thanks all for your input. I'll defer to @colinmegill to guide which testing framework we go with, as I think this is a very important decision for the project, but...

Update: Auspice now has jest / puppeteer support thanks to @tihuan's #943 🎉 @tihuan & @colinmegill do you recommend closing this issue and creating new issues for each of https://github.com/nextstrain/auspice/issues/917#issuecomment-596348566...

👍 @colinmegill / @tihuan if you have time, could you turn one of those example tests into an issue as you're better placed to know how much detail is required...

Hi @tihuan -- thanks for commenting, it's exciting that this is progressing! > Given that it's asserting SVG changes This, to me, is the big question. The datasets which auspice...

> In the meantime I'll work on a prototype and get a PR out for screenshot testing, so we have a concrete example that we can use to discuss pros...

This was somehow missed during #1355. This [TreeTime branch](https://github.com/neherlab/treetime/tree/james/vcf-ref-base-mismatch) includes a test highlighting this.

## Current behaviour Looking across all commands which use `--metadata-id-columns`: ### augur traits We don't distinguish between node-names missing from metadata and node-names in metadata but the trait column (e.g....