James Crowley

Results 54 comments of James Crowley

Currently type is not specified in package.json (so defaults to commonjs), and tsconfig module was set to commonjs

Thanks @micalevisk - that didn't resolve the issue on its own but once setting that flag, I can now see the file type validation fails because the test files are...

@micalevisk we actually encountered this first when doing a minor upgrade on via npm audit fix ("10.3.7" -> "10.4.17" for nestjs common) and then subsequently just decided to go straight...

@micalevisk that importEsmPackage method still triggers a "A dynamic import callback was invoked without --experimental-vm-modules" error for me, at least when defined as this in the JS file: ``` const...

@kettanaito they've decided to [remain CJS only](https://github.com/jshttp/cookie/issues/152), but it appears to work fine with your set up. I just did a [quick PoC here](https://github.com/mswjs/msw/commit/55170984c96d9b5e8d10f8dad53d88c903499b21), removing the bundled es module. Appears...

Also seeing this issue building with vite when we don't have an explicit reference to is-prop-valid in our package.json.

Also working here now. edit: though also seeing other problems like dependencies outside of the root of our mono repo get a package.json update but no lock file, and groups...

FYI I've been able to resolve this issue locally by simply moving the wrapping of err with QueryFailedError to the outer try/catch and throwing it: (https://github.com/jamescrowley/typeorm/compare/master...patch-stack-trace) which appears to align...