James Crowley

Results 54 comments of James Crowley

Yep still need to do boxes, but maybe not a priority for now

I think just copy and paste for now - it's already been simplified a fair amount, and if we spot other patterns we want to optimise (validation might be one...

Rather than assuming CRUD I think it's good to consider the actual *scenarios* around why you'd update or delete - there may be a few, in which case we should...

Just looking for a few more safety nets for the code base in addition to tests, and making refactoring more straightforward - but will need to evaluate how much of...

Some options here: https://github.com/willhlaw/node-firestore-backup-restore/issues/26

@fhenrich33 @pylipp anything I can do to help get this and/or #1460 ready to be merged? :)

👍 I’ll rebase and add some tests to try and capture that behaviour

@jmcook1186 I'm working through regroup as there's a few things to suss out there, but in the meantime, some questions re documenting the aggregation behaviour w/ tests: * It appears...