James Crowley

Results 54 comments of James Crowley

@jmcook1186 @narekhovhannisyan also FYI on the regroup, I *think* the behaviour that makes most sense is to regroup outputs in addition to inputs when in append mode - otherwise we...

I've pushed proposed changes. 1. Regroup is now fed outputs alongside inputs and merges those, when the append flag is set. I did some refactoring prior to the changes to...

@jmcook1186 I was just running the second example in the original ticket (with original inputs, and modified mock observations for a later time), with the compute/group updated for the latest...

@manushak Thanks for taking a look. The current implementation appends to the outputs that already exist in the input manifest, but it does not append to any outputs that exist...

@jawache @zanete I’d be happy to take this one if useful, let me know

@zanete I'm starting with some integration tests set up to capture the requirement defined above. However, several of the current integration tests do not pass locally. For example ``` Executing...

@zanete @jmcook1186 Two questions: 1. In the case of an aggregation and group bys, would you expect these to be applied over the combined (pre-existing and new) outputs, or only...

I've pushed a rough draft here: https://github.com/Green-Software-Foundation/if/pull/932 for discussion to ensure it's along the lines of what you had in mind?

![](https://github.trello.services/images/mini-trello-icon.png) [2.0: FE test/linting improvements from James](https://trello.com/c/cGPi62FA/1545-20-fe-test-linting-improvements-from-james)

I've pointed the migrations config setting to the JS output files from our typescript build but still waiting 3+ minutes for 43 migrations to be checked (even when none of...