Jago Strong-Wright
Jago Strong-Wright
Oh wait maybe it works with the latest commit but I definitely do not think it is correct and it will be wrong in some scenarios e.g. when the inflow...
What happens if you compute the mass flux at i = 2 and i = grid.Nx? I think that it will be conserved in that region since the open boundary...
Also I ran your example as is and I can not reproduce the problem, I get zero mass flux. Update: I checked and I had the code from https://github.com/CliMA/Oceananigans.jl/pull/4539/commits/4e2d6236782f0b02dab2e0b91a8d6604d1659fe7 so...
I spent some time going through the code and I agree now that there is no obvious aymmetry. The only interestying thing I've noticed is that if you set the...
Going through older commits need to change the callback to: ```julia function progress(sim) u, v, w = model.velocities cfl_value = cfl_calculator(model) west_mass_flux = Field(Average(view(u, 1, :, :))) east_mass_flux = Field(Average(view(u,...
I'm struggling to follow exactly what's going on here and I can't reproduce the field in this comment: > So, I'm trying to look into this, and I think the...
> The reference in the docstring suggests 1/12: https://www.sciencedirect.com/science/article/pii/S0045793016304005?casa_token=MiYsFFOBzm0AAAAA:O9fn8l8EY_Wy5eJf-YbsdqThYVTGpKQ9aU3GWr88zfg10QLp-I4u7TfioHIF0y_czWUOx2Cm I think they're getting there a different way but that in equation 39 they're finding the equivalent of setting it to...
Yeah, I'm pretty sure it's because when the coefficient is too small, energy gets trapped at small scales, causing more resolved dissipation. I made a test case [here](https://github.com/CliMA/Oceananigans.jl/blob/d1aed211021c6f11ce102e12974e7031c9766b2f/validation/les/decaying_homogeneous_isotropic_turbulence.jl). The first...
> I'm no longer sure that we need the type `BoundaryAdjacentMean`. Can't we construct a `Field` directly with all of the information it needs, and then call `compute!` on that...
Sorry for jumping into this, I might have missed something. > If we integrate a Face field, I think that index 1 stores the first value, not the neutral value....