Jago Strong-Wright

Results 185 comments of Jago Strong-Wright

So this may be working now, so I'm going to make a branch from this branch and PR it into main, then make them both run at the same time...

This is way way slower for some reason? In #186 (old version of pipeline) the tests finish in

Maybe I should experiment with what we're caching

Ah it realises that these branches are duplicates I think

This does seem a lot more robust now but also a lot slower, I will investigate adding more caching

I don't think we should do it this way since its so slow

> Boundary conditions are hard coded here: > > https://github.com/CliMA/ClimaOcean.jl/blob/514135fc9a1016ec0c32081fe3914e789b3d35ca/src/OceanSimulations/OceanSimulations.jl#L77-L80 Couldn't `ocean_simulation` just have a kwarg e.g. `custom_boundary_conditions` and then a line like: ```julia ocean_boundary_conditions = merge(ocean_boundary_conditions, custom_boundary_conditions) ```

The left boundary for a face field is part of the "interior", I'm not sure it is actually every necessary to step it so the best solution would probably be...

I ran the MWE, and it does not work with the removal of the "secret" boundary storage. If I revert to the commit just before you changed that, then the...