Jago Strong-Wright

Oh yeah, sorry my mistake! I do think we should agree a standard unit for light. Maybe PAR in Einsteins and light intensity (or something else) in W/m^2.

We do watts/m^2

Btw, I've temporarily turned off the automatic testing for this branch since its not testing any of the PISCES stuff anyway yet, and we have a limited quota for testing....

Comment origionally posted by @ciadht in #209: > > This where we're leaving PISCES after the internship: > > PISCES is currently a working and (hopefully) correct model. She can...

Updates: > Changes from Aumount 2015 to match NEMO: > > enhanced quadratic mortality rate for diatoms changes from w_0 + w_1 (1-L) to w_0 + 0.25 w_1 (1 -...

If I can get it done before the meeting on Thursday I'm going to change this to be discrete form because I think that will help a lot with future...

@johnryantaylor I think this is now ready to merge. You can see the (brief) documentation I've written here https://oceanbiome.github.io/OceanBioME.jl/previews/PR178/model_components/biogeochemical/PISCES/PISCES/ with notes on what is different to Aumount, 2015 here https://oceanbiome.github.io/OceanBioME.jl/previews/PR178/model_components/biogeochemical/PISCES/notable_differences/...

@ciadht @hannahmw1, I'm probably going to merge this soon. Thank you for all your work, it was really helpful and I'm not sure I'd have had the dedication to track...

Great to hear from you both! @ciadht I'll message you on slack about it

This PR probably isn't API breaking but there are some major internal changes to support discrete form models so going to bump minor version