Jacob Walls

You can `pip install -r doc/requirements.txt` and then `towncrier create 9403.bugfix` to create a changelog stub.

`if TYPE_CHECKING` behaves the same way as `if False` so my impression is just that this was never implemented because there was never a use case for it until the...

However, #8431 added a different approach for this, so it's worth examining whether we should tweak it or drop it. It probably shouldn't be assuming that we can have one...

@antoniogamizbadger Thanks for the contribution!

> (Shouldn't there be a Never used somewhere ?) This is covered by the call to `assert_never()`, which is annotated to return `Never`. Reverting that part of the patch causes...

Coverage decrease is from moving existing uncovered lines around.

A from-the-hip naive patch that solves #9832 but causes some failures worth understanding: ```diff diff --git a/astroid/bases.py b/astroid/bases.py index 4a684cf1..3dfd71f1 100644 --- a/astroid/bases.py +++ b/astroid/bases.py @@ -44,9 +44,7 @@ if...

Implementation tip: when checking whether the except handlers define a name, raise, or return, consider using `NamesConsumer._defines_name_raises_or_returns()` from #5764

> However, it's still unclear why case 2 was only a false positive for Python 3.9 and older 😬 At a glance, I expect that's because on 3.9 and below,...

TODO: update extended commit message to say "increased" not "completed" indirect coverage of module_loading.py, but will wait for review first.