Tim Ramlot

Results 450 comments of Tim Ramlot

> I noticed some discrepancies with the image tag pattern in v0.5.0 and in v0.6.0. Thanks for noticing this. I did not notice that this was how the current images...

> Talked during the open standup: > > I noticed that the label > > ```yaml > app.kubernetes.io/version: "0.5.0" > ``` > > got removed. I will add it back...

> > The labelselector in a Deployment is also immutable > > You are right, I forgot about `selector.matchLabels` not being mutable on Deployment resources. I propose that we keep...

Updated diff after applying the latest changes included in this PR: ```bash make helm-chart VERSION=v0.6.0-alpha.0 diff -u \

/hold There might be an unforeseen issue: https://github.com/cert-manager/cert-manager/pull/7286#discussion_r1766598552

@alvaroaleman could you take a look at this PR too? It should be purely code cleanup/ re-organisation.

> > Moves all the source logic to the same directory, making it easier to understand and refactor in the future. > > What is or isn't easier to understand...

See https://github.com/cert-manager/openshift-routes/releases/tag/v0.6.0 for the release with the new image tag format.