Tim Ramlot
Tim Ramlot
`rbac` is a field under the `global` section in `values.yaml`: https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml#L31-L35 So, the error you received seems to be correct.
We added Helm values validation in v1.16 (https://github.com/cert-manager/cert-manager/pull/7069 and https://cert-manager.io/docs/releases/release-notes/release-notes-1.16). Unknown values in values.yaml were allowed before, but will now result in an error. We made this change to make...
Adding an Istio 1.24 test sounds like a great solution.
@howardjohn In order to test istio 1.24, we will have to add a file here: https://github.com/cert-manager/istio-csr/tree/main/make/config/istio. We can locally test the test using the following command: `ISTIO_VERSION="1.24.0-alpha.0" make test-e2e`
This worked for me: ``` ISTIO_VERSION="1.24.0-alpha.0" make test-e2e ... Ran 14 of 14 Specs in 75.084 seconds SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 0 Skipped...
/approve /lgtm
@volvera10 `domain` does not seem to be a value that is used in any of the Helm templates? Could you link to where that value is used in the Helm...
Great to hear the issue is confirmed to be fixed.
/approve /lgtm
@ThatsMrTalbot could you split off a few smaller refactor PRs?