Tim Ramlot
Tim Ramlot
@Bobgy could you take a look at this PR? This will improve the stability of cert-manager's pipelines that rely on the go-licenses tool.
As you said, this PR does not reduce/ deduplicate code yet. I'm ok with merging this if you think this will bring us closer to a refactor where it will...
We support multiple PKCS12 encodings in cert-manager, we could also introduce it in trust-manager: https://github.com/cert-manager/cert-manager/blob/e1a1ea959aa23ed72d9d7614b34d58ef420ad1d2/pkg/apis/certmanager/v1/types_certificate.go#L521
@SgtCoDFish is there an easy way to verify that we did not miss any usages of RNG? Anything we can automate?
pkcs12 probably uses `crypto/rand` if no random number generator is injected, so we probably want to inject cmrand there too.
/remove-lifecycle rotten
/approve /lgtm
cert-manager has a similar value: https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml#L1380-L1384