Ivan Grokhotkov
Ivan Grokhotkov
Just a formatting issue left ```diff diff --git a/spi_nand_flash/src/nand.c b/spi_nand_flash/src/nand.c index 61975a4..4791980 100644 --- a/spi_nand_flash/src/nand.c +++ b/spi_nand_flash/src/nand.c @@ -136,13 +136,13 @@ static esp_err_t spi_nand_micron_init(spi_nand_flash_device_t *dev) .command = CMD_READ_ID, .dummy_bits =...
@UnTraDe I'm sorry, I forgot one thing: please increase the version number in https://github.com/espressif/idf-extra-components/blob/d9b31d9cc535c750c517bd700a86a1268072b69c/spi_nand_flash/idf_component.yml#L1 to 0.2.0. Then your changes will be automatically released once the PR is merged.
> So it might be an easy change to just use uint32_t instead? I see no downside to it... @RathiSonika WDYT?
@UnTraDe Sorry for the late reply, I was on leave. You can either add the `uint32_t` change here or in a separate PR, up to you. If the current PR...
@UnTraDe I've pushed one additional fix for CI to pass and cleaned up commit history. I'll merge it as soon as the pipeline passes.
At the moment, [doxybook](https://github.com/espressif/doxybook) only supports a single Doxyfile as input and a single API.md as output. We'll have to change this to make it usable for multiple components in...
@Jayegit Sorry for the late reply. In order to add support for this flash memory, you need to do changes similar to this other PR: https://github.com/espressif/idf-extra-components/pull/327. This involves adding a...
@ESP-YJM LGTM aside the few things mentioned.
@ESP-YJM Thanks for the fixes, just one more thing seems to be remaining: ``` /__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c /__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:234:6: error: function declaration isn't a prototype [-Werror=strict-prototypes] 234 | void check_calc_invalid() | ^~~~~~~~~~~~~~~~~~ /__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:282:6:...
@ESP-YJM Thank you for the contribution!