idf-extra-components icon indicating copy to clipboard operation
idf-extra-components copied to clipboard

Add ccronexpr components for parse CRON expression (IEC-88)

Open ESP-YJM opened this issue 1 year ago • 4 comments

Checklist

  • [x] Component contains License
  • [x] Component contains README.md
  • [x] Component contains idf_component.yml file with url field defined
  • [x] Component was added to upload job
  • [x] Component was added to build job
  • [ ] Optional: Component contains unit tests
  • [ ] CI passing

Change description

Please describe your change here

ESP-YJM avatar Feb 06 '24 11:02 ESP-YJM

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 06 '24 11:02 CLAassistant

@igrr Sorry for taking so long to update. If you have time, please help to review it again.

ESP-YJM avatar Apr 10 '24 11:04 ESP-YJM

@ESP-YJM LGTM aside the few things mentioned.

igrr avatar Apr 19 '24 16:04 igrr

@ESP-YJM Thanks for the fixes, just one more thing seems to be remaining:

/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:234:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  234 | void check_calc_invalid()
      |      ^~~~~~~~~~~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:282:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  282 | void test_expr()
      |      ^~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:634:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  634 | void test_parse()
      |      ^~~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:861:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  861 | void test_bits()
      |      ^~~~~~~~~
/__w/idf-extra-components/idf-extra-components/supertinycron/examples/cron_example/main/cron_example_main.c:896:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
  896 | void app_main()
      |      ^~~~~~~~

Please use (void) in function declarations inside the example to avoid strict-prototypes errors.

igrr avatar May 15 '24 08:05 igrr

@ESP-YJM Thank you for the contribution!

igrr avatar May 21 '24 12:05 igrr