Ivan Grokhotkov comments

Results 405 comments of


                                            Ivan Grokhotkov

Still builds successfully when defining duplicate functions (IDFGH-12819)

> Here's one better: building your sample_project on release/4.4 triggers an infinite loop in the build process. @KaeLL Zip files contain local modification time, and the archive was created in...

feat(espcoredump): Include boot time and unix time in header (IDFGH-12792)

Thanks for the nice improvement idea @nebkat, I left some comments... cc @erhankur

Wifi throughput issue (https file download) with huge waits from stream->available() (IDFGH-10889)

Hi @0x0fe, Just to exclude hardware or environment issue, could you try the attached IDF example on your hardware? It downloads a file and writes it to an SD card....

Wifi throughput issue (https file download) with huge waits from stream->available() (IDFGH-10889)

> while the higher level CPP wrapper has very poor performance? Are you sure this is the case? AFAIK the Arduino HTTP client library isn't a wrapper around an IDF...

FreeType: improve library dependency handling, add example

@fhrbata May I ask you to take a look at this MR, especially the part in e90d4a7bd6780487a737b8dbabd7937074d03756? If you think this is a good idea, I'll add `find_package` support for...

FreeType: improve library dependency handling, add example

@espressif2022 PTAL as well

FreeType: improve library dependency handling, add example

cc @espzav

FreeType: improve library dependency handling, add example

@espressif2022 @suda-morris Could you please help review?

FreeType: improve library dependency handling, add example

Thanks for the review @espzav!

added support for Micron MT29F nand flash (IEC-110)

@UnTraDe the failing clang-tidy job was fixed on the master branch, if your rebase your branch it should get fixed here as well. Pre-commit check has noticed a minor formatting...