Qiang Huang

Results 12 comments of Qiang Huang

LGTM [![Approved with PullApprove](https://img.shields.io/badge/runtime--spec-approved-brightgreen.svg)](https://pullapprove.com/opencontainers/runtime-spec/pull-request/934/?utm_source=github-pr&utm_medium=comment-badge&utm_campaign=opencontainers/runtime-spec)

> 1. Create - This action will create a container sandbox. On Linux, this would be all cgroups and namespaces, excepting pid namespace (assuming all cgroups and namespaces were requested...

@wking I've updated this PR to allow ignore platform specific configuration, now vm based container has to figure out how they can be ignored by other runtimes :( @sameo

I don't think runc is quite robust for nested containers, but for this fix, the idea looks good to me, child container should not block the exit of father container.

@percontation @mruck Current change looks good to me, just needs rebase, thanks.

LGTM @mrunalp @crosbymichael Is it OK that we only add functionalities on legacy cgroup now? [![Approved with PullApprove](https://img.shields.io/badge/default-approved-brightgreen.svg)](https://pullapprove.com/opencontainers/runc/pull-request/2106/?utm_source=github-pr&utm_medium=comment-badge&utm_campaign=opencontainers/runc)

LGTM [![Approved with PullApprove](https://img.shields.io/badge/default-approved-brightgreen.svg)](https://pullapprove.com/opencontainers/runc/pull-request/2106/?utm_source=github-pr&utm_medium=comment-badge&utm_campaign=opencontainers/runc)

ping @Mashimiao @liangchenye @mrunalp

> If we mount the host cgroup tree into the container, we can have the whole view of the host cgroup sub path in the contianier even it's readonly. I...