runtime-spec icon indicating copy to clipboard operation
runtime-spec copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

add RFC requirement for mountLabel

Open Mashimiao opened this issue 8 years ago • 7 comments

Signed-off-by: Ma Shimiao [email protected]

Mashimiao avatar Nov 01 '17 06:11 Mashimiao

ping @opencontainers/runtime-spec-maintainers

Mashimiao avatar Nov 30 '17 03:11 Mashimiao

LGTM

Approved with PullApprove

hqhq avatar Nov 30 '17 05:11 hqhq

@opencontainers/runtime-spec-maintainers PTAL

Mashimiao avatar Dec 01 '17 01:12 Mashimiao

LGTM

TomSweeneyRedHat avatar Dec 01 '17 15:12 TomSweeneyRedHat

@opencontainers/runtime-spec-maintainers PTAL

Mashimiao avatar Mar 05 '18 12:03 Mashimiao

NACK I'm :+1: with @wking https://github.com/opencontainers/runtime-spec/pull/934#pullrequestreview-73498295 here. This would be a conditional MUST (the config generated should've accounted for whether selinux on the host is even supported). Which is needed for the trust model of handing down to the container runtime. But to add a MUST here now, would be a revision in the spec and would be a compatibility issue for the community to need to update to using this newer version of the spec.

vbatts avatar Dec 17 '19 18:12 vbatts

@vbatts: But to add a MUST here now, would be a revision in the spec and would be a compatibility issue for the community to need to update to using this newer version of the spec.

Wouldn't that compatibility issue arise anyway due to deprecating the prestart hooks?

h-vetinari avatar Feb 03 '20 17:02 h-vetinari