Holger Drewes

Results 529 comments of Holger Drewes

Someone should give this another test run on occasion.

Please do not merge in yet, I still have some remarks.

Bundle size will be dramatically reduced by #1916 (MB -> KB), will close here.

Actually: will reopen and just take the above comment as an update. While the bundle size reduction in `Common` is a big step we might want to have a continued...

@axic thanks, that helps a lot! We'll be more cautious here on an eventual decision.

Will close this after the feedback from @axic

Can also reproduce, adding to the analysis here. Put the following code into a script `test.js` and then ran `node test.js`: ```typescript import Common from '@ethereumjs/common' const c = new...

Update: this issue is important and should get some more attention.

This is also not "the solution" [tm], but I guess it would ease things (mid-term) if we - as we are already planning for the VM - remove the `Common`...

(changes to the comment, please read on-site and not in your mail client)