Holger Drewes
Holger Drewes
From my perspective this is neither a bug nor an inconsistency but is a by-design choice. Both the VM and e.g. a block are independent entities. If you create a...
Haven't given this much thought yet, but - yeah - such checks might be worth to add I would say on first thought.
Have updated the title to reflect the latest state of the discussion.
> Do you think we should add explicit checks in the VM and Block in the future? If you add Txs to a Block with the wrong common, it will...
Maybe we just keep this open for some more time without merging, than people have a greater chance to discover. If there is 3rd-party demand here, we can then re-take...
@zmitton Can we regard your comment and some review and then merge or could you respectively go one level deeper and extend this to some review with at least one...
@s1na Yes, of course! I think I get this myself on a second deeper look 😜, so I can also do the review myself (//cc @zmitton). Will directly do, merge...
@s1na When having a look at the [closed PRs](https://github.com/ethereumjs/merkle-patricia-tree/pulls?q=is%3Apr+is%3Aclosed) I would go on with doing a `v3.1.0` release, a bit unsure about #82. Would you go along with this?
Just googled the Travis thing (xfvb refuses to start) and just [drop here](https://travis-ci.community/t/xenial-not-wanting-to-start-xfvb/2397) some possible solution hint thread in case this lasts, would nevertheless assume for now that this is...
@s1na Hmm, can't judge how urgently you need this or how much it would distract you to just "drop in" some unplanned (though very welcome) TS transition. I think it...