John Hendrikx
John Hendrikx
Was it considered to not allow these models to be set to `null` instead? Or to use a Null Object? I'd much prefer this instead of polluting the code with...
> We had a similar discussion on #557. We came to the conclusion that we allow null as a selection or focusmodel and don't set a noop selection model or...
@dannygonzalez You mentioned "There are multiple change listeners on a Node for example, so you can imagine with the number of nodes in a TableView this is going to be...
> If we go this route it warrants updates to the API docs to describe the behavioral changes being introduced. Specifically, the synchronizing of the add / remove listener methods...
> Implementation and tests look good. Left a few minor comments. > > in `ObjectBinding.java`, the change in a previous PR was integrated. I think that you need to merge...
> I am late to the party (should have commented in #675) - "Subscription" is way too generic and overloaded word for a functional interface. Any one who is using...
I made another image that shows what happens when you have a Label that is listening on a long lived property that is protected by using a `when(label::shownProperty)`. The reference...
I think the most important open point for this PR is the name for the new operation to be added to `ObservableValue`. Currently in this PR it is called `when`....
> The fix looks correct and the tests pass. I just wonder why the change to reflection-based construction with `bindingMockClassConstructor`? The Parameterized test constructs some standard Binding objects to run...
> As I started my review I noticed that `unbind` does not null-check its argument `dependencies` like `bind` does and it can lead to NPEs. If it is out of...