John Hendrikx

Results 150 comments of John Hendrikx

The PR title "The sorting of the SortedList can become invalid" seems to imply that the sorting can become incorrect, as in the incorrect order. This is not the case....

> Shift + Click again on Col2 to remove the sort from Col2. The order will stay the same [1, 0, 3, 2], but the expected order is [1, 0,...

> Shouldn't we fail gracefully after LogicalFont::getSlot0Resource if slot0FontResource is finally null? It calls `PrismFontFactory::getDefaultFontResource` -- this function looks practically everywhere to find some kind of font. I think if...

The changes seem to deal with the case where Font Config is unavailable on Linux. I think those changes are fine. However, if it turns out there isn't any font...

This is still a large PR, and I do want to help reviewing it, I will do my best to look it over further this week.

> When the window is restored glass calls notifySize with RESTORED and then notifyRepaint with valid dimensions. Why is the repaint being dropped? Can you give me a bit more...

> My thought on this bug was to fix it in the scenegraph, rather than forcing a complete repaint in the toolkit. The scenegraph tracks the state of what is...

> @hjohn this did not fix the issue for me on macOS 15.3.1 M1 (the reproducer still shows "Initial State" label) @andy-goryachev-oracle Hm, I can't test it on Mac, but...

> This does fix the issue on windows. The issue on mac seems intermittent even without this change, and stays intermittent with this change. > > The change seems to...

This doesn't look like an easy fix; although it fixes the issue for me on Windows, I don't have access to a Mac to fix the problem on that platform...