Christoph Hasse
Christoph Hasse
Hi @jim-easterbrook, I think you raise a valid point. Unsure as to if when somebody might have time to tackle this. But just to reassure you, the method you are...
Hi @derselbst, I thought I could help and quickly provide a fix since I did similar work recently for the nikon maker note.... However, for some reason the `CanonAFInfo` is...
> @hassec Don't worry. I already had a look into the code and found it quite easy to do. Here's my branch. I'll need a few more days to test...
I think it would be a nice idea to investigate if we can extend `test_canon_lenses.py` to also test the lenses defined in `canonRFLensType` Not necessarily for this PR though, but...
I agree with @postscript-dev that it would be nice to introduce these kinds of test images if possible.
@clanmills thanks for the hint. But in this case, I don't think we actually execute these tests anymore. It seems that what you describe above is only part of the...
My main objective was only to get better test coverage to make sure any future refactoring doesn't break anything. I'm surprised that this file isn't handled. But given that we...
@sluge I tried to reproduce this but don't get the same error. Which exiv2 version? Can you try and provide a minimal reproducer?
I guess adding a sentence or two can't hurt. How about something that explains that this is information that is not just read from the file but needs to be...
I think that's a reasonable addition, WDYT @piponazo ?