Oli

Results 591 comments of Oli

OMG, so much green in the CI :star_struck:

I pushed a new tag called `fn/v1.0.6`. So in the PR that depends on it, you can update the `github.com/lightningnetwork/lnd/fn` dependency to `v1.0.6` in `go.mod`.

Maybe the new command should therefore be called `estimatefeerate` to distinguish better between the two use cases?

With `WITNESS_PUBKEY_HASH` you should be guaranteed to receive a new address every time. Are you sure you didn't use `UNUSED_WITNESS_PUBKEY_HASH`? Which would return the _same_ address until some on-chain funds...

Thanks for the PR. I have to say, you're quite brave to tackle this issue... Many have tried before :sweat_smile: To avoid a lot of back-and-forth while reviewing, please make...

I think this might be due to the FSYNC behavior of MacOS. See https://news.ycombinator.com/item?id=30370551.

Replaced by https://github.com/lightningnetwork/lnd/pull/8771.

That sounds like you didn't install Go 1.21 or later correctly. Make sure you uninstalled any previous versions fully.

> `Fee rates larger than or equal to 1BTC/kvB are not accepted` `bitcoind` check again after rebasing on current `master`, this was just fixed (or don't use `bitcoind v27.0`). The...