Oli

Results 582 comments of Oli

Cross compilation fails with: `no space left on device`... Oops, probably need to clear out some of the build caches. EDIT: Cleared out build caches.

Before I'm going to review in detail again, just one comment: It feels weird to me that we would want to support different formats and even fall back values within...

> @guggero I'd like to discuss this issue again anytime you're available. I agree with your thoughts That the changes that this PR proposes add much complexity compared to the...

The `bumpclosefee` command is only for force closes. That was made more clear in a recent PR (https://github.com/lightningnetwork/lnd/pull/8350, not yet in a released version). So using `lncli wallet bumpfee` is...

> I don't get the same thing locally at all. Everything completes just fine. I get the following diff when I run `go mod tidy` in the `fn` directory (with...

Will merge this PR into the staging branch as soon as CI is green. Tracking remaining issues to address before merging into `master` here: https://github.com/lightningnetwork/lnd/issues/8769

This PR should now contain everything from the PoC branch and is ready for review.

@Juaniz367461 any information on why this is needed or what the devcontainer.json even does? Otherwise I'd have to categorize this as a spam PR...

Yes, please take a look at the full PR checklist above and the CI failures.