Oli
I tested this a bit on regtest today. Ran the following test cases: 1. Wallet amount is dust (2000sat): `output amount(-0.00004087 BTC) after subtracting fees(0.00006087 BTC) below dust limit(0.00000573 BTC)`...
I think the unit test you added is sufficient. It does test the added coin selection code. What I mean is to add a new itest (see `lntest/itest`). There you...
@bjarnemagnussen #4588 has been merged, this can now be rebased.
@bjarnemagnussen sorry this didn't make it into 0.14.0. Are you willing to give this another attempt for 0.15? I think we're really close and just need to find another reviewer...
@bjarnemagnussen cool, glad to hear you're willing to see this one through :sweat_smile: can you please re-request review once you were able to rebase? Thanks!
!lightninglabs-deploy mute 2022-Feb-01
> I don't know enough about grpc to comment on this, however grpc is supported on [nginx](https://www.nginx.com/blog/nginx-1-13-10-grpc/) and [kubernetes ingress](https://kubernetes.github.io/ingress-nginx/examples/grpc/) so I figure they must have worked their way around...
> it's not an uncommon pattern to centralize TLS/PKI to other software I understand that, and I do see the need for this feature. I'm just giving you technical reasons...
That is an oversight of a recent PR of mine. https://github.com/btcsuite/btcwallet/blob/master/wallet/import.go#L376-L378 should support importing a raw public key as a Taproot address, so that should be fixed. The `ImportTaprootScript` was...
I think the confusing default values were removed a while ago. What remains is an inconvenience with the CLI library that we use for `lncli`, where the default value of...