Andrew Hughes

Results 65 comments of Andrew Hughes
trafficstars

> /sponsor This was pushed while 8u-dev was closed for rampdown [[0](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html)]. Please don't do this. I'll manually move this to 8u432.

> Mostly good. Weird test errors in GHA, though. Thanks for looking over it again. Which ones do you mean? The download issues and cacert failures aren't related to this...

/approval request Fixes ADLC build with GCC 11+ by passing through compiler flags used for the rest of the HotSpot build. Later versions of OpenJDK are not affected, due to...

Merged with latest jdk8u-dev to bring in @zzambers ' changes to the Windows & alt-Linux builds. All builds now pass and the only test failure seems unrelated (`com/sun/jdi/JdbExprTest.sh`)

> @gnu-andrew I think remaining failure should get fixed by: #497 Ah, thanks for spotting that one and getting it sponsored.

> Hi @gnu-andrew > > Could you review my patch again please? > > Thanks, Leslie Zhai Updated patch looks fine, but can we please open this as a PR...