8315020: The macro definition for LoongArch64 zero build is not accurate.

[xiangzhai]

trafficstars

Hi,

I'd like to backport this patch to jdk8u. common/autoconf/platform.m4 and hotspot/src/os/linux/vm/os_linux.cpp do not apply cleanly due to context difference, but it is easy to resolve them manually.

A native build on LoongArch hardware is tested.

Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html

$ ./build/images/j2sdk-image/bin/java -version
openjdk version "1.8.0_412"
OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)

Loongnix Desktop:

$ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
openjdk version "1.8.0_422-internal"
OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)

The risk of the downport is low.

Thanks, Leslie Zhai

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [ ] JDK-8315020 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8315020: The macro definition for LoongArch64 zero build is not accurate. (Bug - P4 - Requested) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/489/head:pull/489
$ git checkout pull/489

Update a local copy of the PR:
$ git checkout pull/489
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 489

View PR using the GUI difftool:
$ git pr show -t 489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/489.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back lzhai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (6728fd32)
• 00: Full (681fcbb9)

[xiangzhai]

Hi @theaoqi @gnu-andrew

Could you review and sponsor the patch please?

Thanks, Leslie Zhai

[xiangzhai]

/approval request allow Zero build on LoongArch

[openjdk[bot]]

@xiangzhai 8315020: The approval request has been created successfully.

[mlbridge[bot]]

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Sun, 28 Apr 2024, Leslie Zhai wrote:

There?s an unnecessary line in there, I noted that on the web thingy.

The failing s390x build is because this is still using Debian 10 (buster), which has recently been archived.

Do an s!http://(httpredir|deb).debian.org!http://archive.debian.org!g to fix that.

bye, //mirabilos -- Infrastrukturexperte ? Qvest Digital AG Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441 Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg Vorsitzender Aufsichtsrat: Peter N?then

[bridgekeeper[bot]]

@xiangzhai This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[xiangzhai]

Hi @gnu-andrew

Could you review my patch again please?

Thanks, Leslie Zhai

[gnu-andrew]

Hi @gnu-andrew

Could you review my patch again please?

Thanks, Leslie Zhai

Updated patch looks fine, but can we please open this as a PR against https://github.com/openjdk/jdk8u ? We can then get this fixed in the July release, but we only have next week to do this. Thanks.

[xiangzhai]

Hi @gnu-andrew Could you review my patch again please? Thanks, Leslie Zhai

Updated patch looks fine, but can we please open this as a PR against https://github.com/openjdk/jdk8u ? We can then get this fixed in the July release, but we only have next week to do this. Thanks.

Could you review the patch please? https://github.com/openjdk/jdk8u/pull/56

Thanks, Leslie Zhai

[jerboaa]

This one needs to close if it gets integrated with https://github.com/openjdk/jdk8u/pull/56