jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8326529: JFR: Test for CompilerCompile events fails due to time out
This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8
This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).
Testing: the updated jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java test passes.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8326529 needs maintainer approval
Issue
- JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4 - Requested)
Reviewers
- Severin Gehwolf (@jerboaa - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/484/head:pull/484
$ git checkout pull/484
Update a local copy of the PR:
$ git checkout pull/484
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/484/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 484
View PR using the GUI difftool:
$ git pr show -t 484
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/484.diff
Webrev
:wave: Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@roberttoyonaga This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8326529: JFR: Test for CompilerCompile events fails due to time out
Reviewed-by: sgehwolf
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 7 new commits pushed to the master branch:
- 012f59c7f63fc44c1949d905203ea3f449087cd4: 8316138: Add GlobalSign 2 TLS root certificates
- 7bcaeb5ff10a0269b43743a4ba6529615dde7aa2: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
- ab408debf4afeb02ee6ae9339950559f152fe255: 8235834: IBM-943 charset encoder needs updating
- b3308b1ea0cb5746d025fe2bb1f3317dc7033cf6: 8328825: Google CAInterop test failures
- 216b8cbf51f8f5f020a57dabb763c27b36899c12: 8331791: [8u] AIX build break from JDK-8320005 backport
- 853a87a8e4c4a075e19ddcd6d3d4a7a924967f32: 8293562: KeepAliveCache Blocks Threads while Closing Connections
- 89def4d2c94f5e174f704318f31fb85a1fee4561: 8331980: [8u] Problem list CAInterop.java#certignarootca test
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request for the backport of a JFR test case fix. Should be very low risk since it's only a small change to test case code.
The GHA failures do not seem to be related to this change, and are failing for the other PRs as well.
It the tests are failing with the following message:
PKIX path validation failed: java.security.cert.CertPathValidatorException: Certificate does not specify OCSP responder
@roberttoyonaga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@roberttoyonaga Your change (at version 7e4623707464309b1189a6e29bc5c463bc3218c4) is now ready to be sponsored by a Committer.
Going to push as commit db860f0cf8bd5b47516508be170f930710e5e396.
Since your change was applied there have been 7 commits pushed to the master branch:
- 012f59c7f63fc44c1949d905203ea3f449087cd4: 8316138: Add GlobalSign 2 TLS root certificates
- 7bcaeb5ff10a0269b43743a4ba6529615dde7aa2: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
- ab408debf4afeb02ee6ae9339950559f152fe255: 8235834: IBM-943 charset encoder needs updating
- b3308b1ea0cb5746d025fe2bb1f3317dc7033cf6: 8328825: Google CAInterop test failures
- 216b8cbf51f8f5f020a57dabb763c27b36899c12: 8331791: [8u] AIX build break from JDK-8320005 backport
- 853a87a8e4c4a075e19ddcd6d3d4a7a924967f32: 8293562: KeepAliveCache Blocks Threads while Closing Connections
- 89def4d2c94f5e174f704318f31fb85a1fee4561: 8331980: [8u] Problem list CAInterop.java#certignarootca test
Your commit was automatically rebased without conflicts.
@jerboaa @roberttoyonaga Pushed as commit db860f0cf8bd5b47516508be170f930710e5e396.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
/sponsor
This was pushed while 8u-dev was closed for rampdown [0]. Please don't do this.
I'll manually move this to 8u432.
