Geoffrey White

I've run the tests on this PR, and it looks like you need to autoformat the QL file. Let me know if you don't know how to do this. ```...

> I think @Yonah125 is done with this after his latest push. How does this look ? Yes I think you're right. Its looks promising but a little unfinished to...

I'm just looking at a possible performance issue on this PR...

> Do we want to run a DCA on this once you've fixed the performance issue? I'm actually fairly confident, the issue was an uncomplicated cartesian product. I will start...

Yep, I'm not surprised if it removes a lot of results (and some of them will be TPs), but we should check at least a proportion of them are really...

Do you know where to find the total number of results for `cpp/unused-static-function` in the DCA run? Losing 236 is a lot, but I have a feeling its a noisy...

I think it would be useful in cases like this, yes, but I'm tracking a million things today already. Feel free to talk to them.

DCA: I'm ignoring the 5% overall increase in query run times, because this is a change to one QL file and it isn't very plausible its had an effect on...

I've just done the change to just basing this on `Diagnostic`s, not `ErrorExpr`s. Tests still pass. There are now 717 MRVA results on 69 repos (8% less than original). Does...

DCA showed: - 107 fixed alerts for `cpp/unused-static-function` in `systemd__systemd`, 32 in `zeek__spicy` and 1 in `microsoft__ChakraCore`. - the 54 (dubious) changes to results on `Kitware__CMake` from the previous DCA...