Geoffrey White
Geoffrey White
DCA: - 95 results for the new query; that's quite a lot... - confusing results that have sources in macros - fixed ✅ - results matching `self`; I think this...
Thanks for the review @mchammer01 , I've accepted both suggestions. :)
CI is finally passing :tada: (thanks again @redsun82 for spotting and fixing the problem here) @hvitved would you mind approving?
... I've tried and so far failed to write a test exposing the behaviour of `getExtentOverlap` in this case. I _have_ confirmed how it performs locally with a small range...
> If you want to find a query thst exercises the changes here, you can pick a query that uses the MustFlow library That can't be right, there's a large...
I've just pushed two commits adding a (direct) test and then showing the difference this change makes. I'm much less experienced with the alias analysis logic than you are, but...
> On the flip side, the `MayPartiallyOverlap` results were probably correct (and I'm not exactly sure why we lose them yet). It's caused by the additional logic in `getOverlap`, transforming...
@MathiasVP I'm waiting for your opinion about the test I added in the last two commits. I'm keen to get this performance issue solved but I'm struggling with lack of...
I just had a look for the same problem on a couple more projects we've had performance troubles with lately (`Miseryset/Android-ImageMagick7` and `Sphereserver/Source-X`) that we suspected might be related -...