Jiawen Geng

Results 264 comments of Jiawen Geng

> > broken on windows arm64 cc @nodejs/platform-arm @StefanStojanovic > > ``` > > 11:04:03 'C:\Python310\python_host.exe' is not recognized as an internal or external command, > > 11:04:03 operable program...

@nodejs/tsc Seems windows-arm not responding, can you help on this one. This has been a huge pain on newer linux and macOS (only python3 is available)

> > @nodejs/tsc Seems windows-arm not responding, can you help on this one. > > You want to be pinging @nodejs/platform-windows-arm for Windows on ARM. Looks windows-arm not responding at...

Once again @nodejs/tsc @mhdawson @nodejs/platform-windows-arm

> I think V8 built fine. There's an error in `env.cc`: > > ``` > FAILED: obj/src/libnode.env.o > c++ -MMD -MF obj/src/libnode.env.o.d -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -D_GLIBCXX_USE_CXX11_ABI=1 -DNODE_OPENSSL_CONF_NAME=nodejs_conf -DNODE_OPENSSL_HAS_QUIC -D_DARWIN_USE_64_BIT_INODE=1 -DOPENSSL_NO_PINSHARED -DOPENSSL_THREADS...

``` gen/node_snapshot.cc:620:16: error: no matching constructor for initialization of 'node::SnapshotData' };SnapshotData snapshot_data { ^ ~ ../../src/env.h:574:3: note: candidate constructor not viable: requires 1 argument, but 6 were provided SnapshotData(const SnapshotData&)...

Most platforms build passed. MSVC comes no surprise, v8 failed on MSVC. ```console 15:01:24 C:\workspace\node-compile-windows\node\deps\v8\src\handles\handles.h(143,37): error C2027: use of undefined type 'v8::internal::Object' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj] ```

> > Most platforms build passed. MSVC comes no surprise, v8 failed on MSVC. > > ``` > > 15:01:24 C:\workspace\node-compile-windows\node\deps\v8\src\handles\handles.h(143,37): error C2027: use of undefined type 'v8::internal::Object' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj] >...

> Ha, msvc gets confused by the `namespace foo::bar {` syntax. That's a C++17-ism. > > You can fix it by breaking it up into `namespace foo { namespace bar...

> Issue should be fixed in the next minor version of VS2022: [developercommunity.visualstudio.com/t/cpp20-nested-namespace-cant-compile/10328893#T-ND10330571](https://developercommunity.visualstudio.com/t/cpp20-nested-namespace-cant-compile/10328893#T-ND10330571) 17.6 is released, but not on github actions yet.